Skip to content

Always rename props on build#831

Draft
andrewiggins wants to merge 1 commit intomainfrom
rename-props-on-nonminified
Draft

Always rename props on build#831
andrewiggins wants to merge 1 commit intomainfrom
rename-props-on-nonminified

Conversation

@andrewiggins
Copy link
Member

@andrewiggins andrewiggins commented Jan 21, 2026

Note: this is dependent on preactjs/babel-plugin-transform-rename-properties#12 to work

I'd like to produce non-minified builds of signals to help debug issues. So I've copied the same babel transform we use in Preact to always rename properties regardless of whether microbundle is minifying or not (--no-compress).

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2026

⚠️ No Changeset found

Latest commit: bc8cfc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jan 21, 2026

Deploy Preview for preact-signals-demo failed.

Name Link
🔨 Latest commit bc8cfc5
🔍 Latest deploy log https://app.netlify.com/projects/preact-signals-demo/deploys/69853ab8d979c700072ddb8d

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

Size Change: -10.2 kB (-6.16%) ✅

Total Size: 156 kB

Filename Size Change
docs/dist/assets/bench-********.js 1.6 kB +2 B (+0.13%)
docs/dist/assets/client-********.js 46.5 kB +46.5 kB (new file) 🆕
docs/dist/assets/client-BJrXu7B-.js 0 B -46.5 kB (removed) 🏆
docs/dist/assets/devtools-********.js 913 B -1 B (-0.11%)
docs/dist/assets/index-********.js 1.2 kB +366 B (+43.68%) 🚨
docs/dist/assets/index-COaMW-YH.js 0 B -8.32 kB (removed) 🏆
docs/dist/assets/index-CXzBB0-O.js 0 B -1.21 kB (removed) 🏆
docs/dist/assets/index-Dqk-Nbz1.js 0 B -1.09 kB (removed) 🏆
docs/dist/assets/signals-core.module-********.js 1.76 kB +1 B (+0.06%)
docs/dist/assets/utils.module-********.js 400 B -1 B (-0.25%)
docs/dist/basic-********.js 246 B +246 B (new file) 🆕
docs/dist/basic-fj9OT-hk.js 0 B -246 B (removed) 🏆
docs/dist/nesting-********.js 0 B -1.14 kB (removed) 🏆
docs/dist/nesting-nh7BlxI-.js 1.15 kB +1.15 kB (new file) 🆕
docs/dist/react-********.js 0 B -239 B (removed) 🏆
docs/dist/react-BglNC-GW.js 242 B +242 B (new file) 🆕
packages/core/dist/signals-core.mjs 1.79 kB +1 B (+0.06%)
packages/preact/dist/signals.js 1.76 kB +1 B (+0.06%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/EmbeddedDevtools-********.js 15.9 kB
docs/dist/assets/jsxRuntime.module-********.js 300 B
docs/dist/assets/preact.module-BXh5-_sV.js 4.74 kB
docs/dist/assets/signals.module-********.js 2.6 kB
docs/dist/assets/style-********.css 4.12 kB
docs/dist/assets/Unmount-********.js 652 B
packages/core/dist/signals-core.js 1.79 kB
packages/debug/dist/debug.js 4.55 kB
packages/debug/dist/debug.mjs 4.07 kB
packages/devtools-adapter/dist/devtools-adapter.js 2.17 kB
packages/devtools-adapter/dist/devtools-adapter.mjs 1.88 kB
packages/devtools-ui/dist/devtools-ui.js 14.5 kB
packages/devtools-ui/dist/devtools-ui.mjs 14 kB
packages/preact-transform/dist/signals-*********.js 1.3 kB
packages/preact-transform/dist/signals-transform.mjs 1.29 kB
packages/preact-transform/dist/signals-transform.umd.js 1.42 kB
packages/preact/dist/signals.mjs 1.71 kB
packages/react-transform/dist/signals-*********.js 7.28 kB
packages/react-transform/dist/signals-transform.mjs 6.47 kB
packages/react-transform/dist/signals-transform.umd.js 7.39 kB
packages/react/dist/signals.js 214 B
packages/react/dist/signals.mjs 165 B

compressed-size-action

I'd like to produce non-minified builds of signals to help debug issues. So I've copied the same babel transform we use in Preact to always rename properties regardless of whether microbundle is minifying or not (`--no-compress`).
@andrewiggins andrewiggins force-pushed the rename-props-on-nonminified branch from 2306a97 to bc8cfc5 Compare February 6, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant